Skip to content

Conversation

@zzq0826
Copy link
Member

@zzq0826 zzq0826 commented Jul 17, 2024

Adjust Document Dark Mode Text Color
The current text color in dark mode has a high contrast that is uncomfortable for reading. Adjust the text color to reduce the contrast and enhance readability.

@netlify
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit d554c8f
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/669db1b5d5b2b50008a859d0
😎 Deploy Preview https://deploy-preview-303.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zzq0826 zzq0826 requested a review from dghelm July 18, 2024 00:26
@dghelm
Copy link
Contributor

dghelm commented Jul 18, 2024

I like the direction of this. I feel like the contrast now is too low, but if you're a regular dark mode user, I'll defer to your judgement here.

There are errors in rendering the Tabs component:
image

@ConstantineMorningStaRXyZ
Copy link

@zzq0826
Copy link
Member Author

zzq0826 commented Jul 22, 2024

I like the direction of this. I feel like the contrast now is too low, but if you're a regular dark mode user, I'll defer to your judgement here.

There are errors in rendering the Tabs component: image

The tabs style has been fixed and the contrast has been adjusted. @dghelm

@dghelm dghelm merged commit 1dd9c08 into develop Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants