-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Labels
bugSomething isn't workingSomething isn't workingdatabaseenginemilestone 5This issue is part to Milestone 5 of the Rollup Node planThis issue is part to Milestone 5 of the Rollup Node plan
Milestone
Description
Overview
If we reorg during L1 Consolidation, we should update the RNM so that we can make other components consistent with the EngineDriver. We should introduce a new event type EngineDriverEvent::L1BlockReorg and emit it.
rollup-node/crates/engine/src/driver.rs
Lines 130 to 148 in bdfee09
| EngineDriverFutureResult::L1Consolidation(result) => { | |
| tracing::info!(target: "scroll::engine", ?result, "handling L1 consolidation result"); | |
| match result { | |
| Ok((block_info, reorg, batch_info)) => { | |
| // Update the safe block info and return the block info | |
| tracing::trace!(target: "scroll::engine", ?block_info, "updating safe block info from block derived from L1"); | |
| self.fcs.update_safe_block_info(block_info); | |
| // If we reorged, update the head block info | |
| if reorg { | |
| tracing::warn!(target: "scroll::engine", ?block_info, "reorging head to l1 derived block"); | |
| self.fcs.update_head_block_info(block_info); | |
| } | |
| return Some(EngineDriverEvent::L1BlockConsolidated(( | |
| block_info, batch_info, | |
| ))) | |
| } |
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdatabaseenginemilestone 5This issue is part to Milestone 5 of the Rollup Node planThis issue is part to Milestone 5 of the Rollup Node plan
Type
Projects
Status
Done