forked from paradigmxyz/reth
-
Notifications
You must be signed in to change notification settings - Fork 7
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Describe the feature
Transactions reaching the tx pool should be rejected if their rollup fee reaches a value > u64::MAX.
Additional context
Modify the ScrollTransactionValidator::validate_one in order to verify that the additional rollup fee cost is lower than u64::MAX.
reth/crates/scroll/txpool/src/validator.rs
Lines 171 to 183 in b2377df
| let cost_addition = match l1_block_info.l1_tx_data_fee( | |
| self.chain_spec(), | |
| self.block_timestamp(), | |
| self.block_number(), | |
| &encoded, | |
| Some(compression_ratio), | |
| false, | |
| ) { | |
| Ok(cost) => cost, | |
| Err(err) => { | |
| return TransactionValidationOutcome::Error(*valid_tx.hash(), Box::new(err)) | |
| } | |
| }; |
Related l2geth PR: scroll-tech/go-ethereum#1203
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Type
Projects
Status
Done