Skip to content

Transactions with rollup fee > u64::MAX at tx pool #305

@greged93

Description

@greged93

Describe the feature

Transactions reaching the tx pool should be rejected if their rollup fee reaches a value > u64::MAX.

Additional context

Modify the ScrollTransactionValidator::validate_one in order to verify that the additional rollup fee cost is lower than u64::MAX.

let cost_addition = match l1_block_info.l1_tx_data_fee(
self.chain_spec(),
self.block_timestamp(),
self.block_number(),
&encoded,
Some(compression_ratio),
false,
) {
Ok(cost) => cost,
Err(err) => {
return TransactionValidationOutcome::Error(*valid_tx.hash(), Box::new(err))
}
};

Related l2geth PR: scroll-tech/go-ethereum#1203

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions