Incorrect state root

[frisitano]

Describe the bug

When running the e2e test in the scroll node crate we receive the following warning logs:

2025-04-03T16:17:51.348002Z  WARN engine::tree: State root task returned incorrect state root state_root=0x24ee42b8bfb323b1b105051190f9230ada458ece6cfcdb93c861beaecffc2ba8 block_state_root=0xa8af761a5caae1c7931015cbe3c1c2450ead5bee60a8a9aadd312645731f80ee
2025-04-03T16:17:51.348019Z  WARN engine::tree: Failed to compute state root in parallel block=NumHash { number: 89, hash: 0xafa014cdebc345b7c720da907ff20281f1a0669e215cf9fec724b1a2cec95705 } persisting_kind=PersistingDescendant
2025-04-03T16:17:51.405939Z  WARN engine::tree: State root task returned incorrect state root state_root=0xa8af761a5caae1c7931015cbe3c1c2450ead5bee60a8a9aadd312645731f80ee block_state_root=0xba443bbe8231b665a152c9ae99b14b20130f2b23c6d17b744a15b6f5d946cbd0
2025-04-03T16:17:51.405955Z  WARN engine::tree: Failed to compute state root in parallel block=NumHash { number: 90, hash: 0xd8a8a32816737d115e9a4730355ed7856e4eb3689f7794427c19621d70c9d4cc } persisting_kind=PersistingDescendant

I suspect this is due to the fact that the test uses a custom genesis configuration and the state root for the genesis block is not being dynamically computed at runtime. We should investigate this to confirm this thesis and apply a fix.

Steps to reproduce

N/A

Node logs

Platform(s)

No response

Container Type

Not running in a container

What version/commit are you on?

scroll branch

What database version are you on?

scroll branch

Which chain / network are you on?

scroll-mainnet

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

• I agree to follow the Code of Conduct

[greged93]

I'm not entirely sure this issue comes from an incorrect genesis configuration, I believe it just comes from the fact that the parallel state root computation task doesn't compute the root fast enough, actually returning the state root from the previous block (the reason why I'm not too sure).

The state root computation then falls back to computing the root in sync here, issuing the second warning you see:

reth/crates/engine/tree/src/tree/mod.rs

Line 2214 in a37dcd5

// fallback is to compute the state root regularly in sync

[greged93]

@frisitano can this be closed?