Skip to content

Conversation

@georgehao
Copy link
Member

@georgehao georgehao commented Nov 17, 2025

1. Purpose or design rationale of this PR

Bump the da-code version, incorporate V9 codec encoding into l2geth rollup-verifier: scroll-tech/da-codec#66

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Updated core dependencies to stable release versions.
    • Bumped patch version number.

@georgehao georgehao requested a review from Thegaram November 17, 2025 02:48
@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025

Walkthrough

This PR updates the github.com/scroll-tech/da-codec dependency from a pseudo-version to stable release v0.9.0 in go.mod, and bumps the patch version from 11 to 12 in params/version.go.

Changes

Cohort / File(s) Change Summary
Dependency Update
go.mod
Updated github.com/scroll-tech/da-codec from pseudo-version v0.1.3-0.20250825071838-cddc263e5ef6 to stable release v0.9.0
Version Bump
params/version.go
Incremented patch version constant from 11 to 12, affecting Version and VersionWithMeta outputs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

bump-version

Suggested reviewers

  • Thegaram
  • jonastheis

Poem

🐰 A hop, a skip, a version bump we go,
Da-codec shines with v0.9's glow,
From pseudo to stable, the path is clear,
Twelve's the magic number this release year! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description uses the provided template but leaves all checklist items unchecked, including the required conventional commits type selection and version update confirmation. Check the appropriate boxes in the description template to confirm conventional commits type adherence, version update status, and breaking change assessment.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'Feat/bump da codec' follows conventional commits format with 'feat' type and clearly describes the main change (bumping da-codec dependency).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/bump_da_codec

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 906b730 and 76237c0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (1 hunks)
  • params/version.go (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-09T19:18:56.758Z
Learnt from: Thegaram
Repo: scroll-tech/go-ethereum PR: 1245
File: crypto/kzg4844/kzg4844_gokzg.go:118-150
Timestamp: 2025-10-09T19:18:56.758Z
Learning: The scroll-tech/go-ethereum repository uses Go 1.22+ and supports range-over-integer syntax such as `for range n` and `for i := range len(slice)`, which are valid Go 1.22 language features.

Applied to files:

  • go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
params/version.go (1)

27-27: LGTM! Patch version increment is appropriate.

The patch version bump from 11 to 12 is consistent with the dependency update in go.mod.

go.mod (1)

56-56: Verify V0.9.0 codec changes are compatible with blob decoding and DA batch processing.

v0.9.0 introduces Codec V9 (galileo) with updated compressed-data compatibility logic and new RLE/ZSTD block handling. The codec now uses V9 compatibility checks by default, and downstream code that decodes/validates Scroll DA blobs or estimates L1 commit sizes should be tested/updated accordingly.

The codebase uses da-codec for blob decoding in commitV7.go, DA chunk decoding in commitV0.go and commitV1.go, and related operations in rollup_fee.go, da.go, and reader.go. Verify that these decoder functions (codec.DecodeBlob(), codec.DecodeDAChunksRawTx(), codec.DecodeTxsFromBlob()) remain compatible with V9's new compression compatibility rules and blob construction behavior, and run integration tests to ensure DA batch processing works correctly with the updated codec.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@georgehao georgehao merged commit b5c3dd1 into develop Nov 17, 2025
14 checks passed
@georgehao georgehao deleted the feat/bump_da_codec branch November 17, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants