Skip to content

Conversation

mcalancea
Copy link
Collaborator

@mcalancea mcalancea commented Jan 7, 2025

This PR adds benches/ files exercising the quadratic_sorting and is_prime examples (the latter added in this PR). The benches target the E2EProving segment.

I've temporarily commented out a couple of things to make things work. They need to be addressed:

  • Use of debug_memory_ranges in src/e2e.rs.
  • Use of println! in guests. The reason is that the contents of these prints are stored into a memory range which is not included in writable memory when using the default heap sizes.

Additionally, I've renamed bubble_sorting to quadratic_sorting which I think matches the guest code better.

Later Edit:

  • Confirmed with Aurel that debug_memory_ranges can be removed entirely.

@matthiasgoergens
Copy link
Contributor

matthiasgoergens commented Jan 7, 2025

Thanks!

We can completely remove the debug prints in the guests for now. Just make sure to have an assert or so inside the guest to make sure we got the right answers?

I'm also having trouble with debug_memory_ranges and hints in my sproll-evm benchmark branch. I guess we should use git blame to do some code archaeology to see what the historic context to the design decisions in this context was.

Copy link
Contributor

@matthiasgoergens matthiasgoergens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if GitHub works now..

github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
In preparation for #813

Also stop hard-coding the examples in the examples-builder.
@mcalancea mcalancea marked this pull request as ready for review January 9, 2025 17:13
@lightsing lightsing mentioned this pull request Apr 16, 2025
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2025
to try, in ceno/ceno_cli/example dir, run: 
```
$ cargo install --path .. --locked
$ cargo ceno run --release --hints 10 --public-io 4 --out-proof proof.bin --out-vk vk.bin
```

- [x] cargo ceno build
- [x] cargo ceno run
- [x] cargo ceno keygen
- [x] cargo ceno prove
- [x] cargo ceno verify

resolve #876

close #813
close #814
close #818
close #819

---------

Co-authored-by: Mihai <[email protected]>
Co-authored-by: Matthias Goergens <[email protected]>
@lispc lispc closed this in #902 Apr 16, 2025
ThomasJarviskayleahirvjy added a commit to ThomasJarviskayleahirvjy/deep-prove that referenced this pull request Oct 9, 2025
In preparation for scroll-tech/ceno#813

Also stop hard-coding the examples in the examples-builder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants