-
Notifications
You must be signed in to change notification settings - Fork 61
fallback to SHUB_JOBAUTH environment variable if SH_APIKEY is not set #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
you can test with the command 'py.test tests/client/test_utils.py' I'm also adding requirements-base.txt to the requirements-test.txt file as we need some libs installed from this file to perform some tests
requirements-test.txt
Outdated
| @@ -1,3 +1,5 @@ | |||
| -r requirements-base.txt | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the general idea here is:
- when you need to simply install a package, you install everything from requirements.txt
- when you want to install test-related packages, you install it additionally, with separate
pip install -rcmd
So for me it's a matter of taste and I don't see any strong reason to change it.
Do you agree or I'm missing anything else here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think this line is not needed. Also, it is a different discussion/feature than the one intended for this PR. I would remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced about the change in requirements-test.txt and would prefer to drop it.
Apart from that, LGTM, very neat changes 👍
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 93.39% 93.41% +0.01%
==========================================
Files 28 28
Lines 1878 1883 +5
==========================================
+ Hits 1754 1759 +5
Misses 124 124
Continue to review full report at Codecov.
|
|
Great. I have removed the changes from the requirements file in order to keep the scope of this PR attached to the original discussion. |
|
Thanks @victor-torres! |
you can test with the command
py.test tests/client/test_utils.pyI'm also adding requirements-base.txt to the requirements-test.txt file as we need some libs installed from this file to perform some tests
This fixes issue #103