Add Python 3.10 to CI #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2021
garfieldnate
added a commit
to garfieldnate/python-crfsuite
that referenced
this pull request
Dec 9, 2021
This provides compatibility with Python 3.10. Fixes scrapinghub#130, scrapinghub#131, scrapinghub#132.
Gerrit-K
added a commit
to Gerrit-K/python-crfsuite
that referenced
this pull request
Jan 17, 2022
Otherwise the `then` block would only be executed for python 3.10, with all other versions being ignored. Refs scrapinghub#130, scrapinghub#131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: There are build errors on Python 3.10 (#130).
Solution: This doesn't solve them, but it builds on top of #124 to at least add Python 3.9 and 3.10 to the build matrix.
EDIT: It seems like CI isn't working?