Skip to content

Conversation

sibiryakov
Copy link
Member

Targeting:

  • new async client,
  • message corruption,
  • DBW and SW hanging.

@sibiryakov sibiryakov force-pushed the kafka-10x branch 3 times, most recently from 91cd574 to b94f6c0 Compare May 11, 2016 12:35
@sibiryakov sibiryakov changed the title [WIP] Kafka client 1.0.x refactoring Kafka client to support 1.0.x kafka-python versions May 11, 2016
@sibiryakov
Copy link
Member Author

sibiryakov commented May 26, 2016

The summary is:

  • With Kafka 0.8.2.1 None of the consumers in Kafka-python works normally, or at least I wasn't able to make them do so. KafkaConsumer doesn't support offsets auto commits (it works starting from kafka 0.9.0). SimpleConsumer crashes when committing offsets and consuming at the same time. See SimpleConsumer throws error when committing offsets dpkp/kafka-python#707
  • Sometimes when consuming spider reports error
Traceback (most recent call last):
  File "/Users/sibiryakov/src/sh/kafka-python/kafka/future.py", line 33, in success
    self._call_backs('callback', self._callbacks, self.value)
  File "/Users/sibiryakov/src/sh/kafka-python/kafka/consumer/fetcher.py", line 656, in _handle_fetch_response
    elif error_type in (Errors.NotLeaderForPartitionError,
TypeError: 'FetchResponse_v0' object has no attribute '__getitem__'

@sibiryakov
Copy link
Member Author

I think, it would be better to wait till kafka-python will be working properly for kafka 0.8. Otherwise by merging this code we make frontera incompatible with this Kafka version.

@sibiryakov
Copy link
Member Author

If auto-commit will be fixed it would be possible to drop KAFKA_USE_SIMPLE_CONSUMER option.

@sibiryakov
Copy link
Member Author

closed in favor of #223

@sibiryakov sibiryakov closed this Nov 18, 2016
@sibiryakov sibiryakov deleted the kafka-10x branch November 18, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant