Skip to content

MAINT: 1.7.x version pins ("backport") #14145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

MAINT: 1.7.x version pins ("backport") #14145

merged 2 commits into from
May 27, 2021

Conversation

tylerjereddy
Copy link
Contributor

@rgommers Chances are this isn't quite right yet--it mostly borrows from the changes in the previous release branch, so maybe some versions can be slightly higher..

@tylerjereddy tylerjereddy added this to the 1.7.0 milestone May 27, 2021
rgommers
rgommers reviewed May 27, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but we'll need some upper bounds for other build dependencies (setuptools, pythran) as well. I'll have a look at updating those.

@tupui
Copy link
Member

tupui commented May 27, 2021

In the pyproject.toml shouldn't we remove the references to Python 3.6?

@rgommers
Copy link
Member

In the pyproject.toml shouldn't we remove the references to Python 3.6?

Yes, we can indeed. We may also be missing some python_version specifiers for 3.8-3.9 for aarch64, as well as AIX specifiers. I'll compare with oldest-supported-numpy.

@rgommers rgommers added the Official binaries Items related to the official SciPy binaries, including wheels and vendored libs label May 27, 2021
rgommers
rgommers reviewed May 27, 2021
View reviewed changes
@rgommers
Copy link
Member

That cleans it up a bit. We only need three sets of requirements: aarch64, PyPy and the default ones.

@tylerjereddy
Copy link
Contributor Author

Thanks Ralf and Pamphile, I'll put this backport in

@tylerjereddy tylerjereddy merged commit 9356be7 into scipy:maintenance/1.7.x May 27, 2021
@tylerjereddy tylerjereddy deleted the treddy_170_version_pins branch May 27, 2021 21:36
rgommers added a commit to rgommers/scipy that referenced this pull request May 29, 2021
@rgommers
BLD: update pyproject.toml - add macOS M1, drop py36
a74e827 
Changes taken over from scipygh-14145 and from
scipy/oldest-supported-numpy#20
@rgommers rgommers mentioned this pull request May 29, 2021
Merged
@tylerjereddy tylerjereddy mentioned this pull request Jun 1, 2021
Merged
rgommers added a commit to rgommers/scipy that referenced this pull request Jun 2, 2021
@rgommers
BLD: update pyproject.toml - add macOS M1, drop py36
0bd0706 
Changes taken over from scipygh-14145 and from
scipy/oldest-supported-numpy#20
@tylerjereddy tylerjereddy mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

Assignees
No one assigned
Labels
Official binaries Items related to the official SciPy binaries, including wheels and vendored libs
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerjereddy @tupui @rgommers