Skip to content

Conversation

DominikKamp
Copy link
Contributor

@DominikKamp DominikKamp commented May 6, 2025

This fixes compilation for SCIP master on Mac with Homebrew.

@DominikKamp DominikKamp requested a review from Joao-Dionisio May 6, 2025 13:52
@DominikKamp DominikKamp mentioned this pull request May 6, 2025
10 tasks
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.46%. Comparing base (1db095e) to head (94a6fb9).
Report is 83 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   52.54%   53.46%   +0.92%     
==========================================
  Files          20       22       +2     
  Lines        4345     4962     +617     
==========================================
+ Hits         2283     2653     +370     
- Misses       2062     2309     +247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joao-Dionisio
Copy link
Member

It looks like it makes sense, @DominikKamp. But how would one test this? It's something that will impact everyone, that's why I'm a bit concerned about sending it untested.

@DominikKamp
Copy link
Contributor Author

It affects Linux and Mac systems where there could be a brewed GMP. So better check this location as well. I have tested the updated branch and the tests seem to pass, otherwise you can just blame it on me.

@Joao-Dionisio Joao-Dionisio merged commit 01e2354 into master May 6, 2025
3 checks passed
@Joao-Dionisio Joao-Dionisio deleted the fix-include-mac branch August 7, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants