Skip to content

Conversation

@Joao-Dionisio
Copy link
Member

@Joao-Dionisio Joao-Dionisio commented Mar 25, 2024

Fix #788.

Following the internal discussion, I've decided to go along and set the locale back and forth, whenever the user writes or prints anything.

Some people thought that this might be too expensive, so if you feel the same, please say so :)

EDIT: Ah, the tests are failing because locales might be OS-specific. They're passing on my end.

@codecov
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 19.56522% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 52.18%. Comparing base (d1a9895) to head (0717bb3).

Files Patch % Lines
src/pyscipopt/scip.pxi 19.56% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   52.49%   52.18%   -0.31%     
==========================================
  Files          18       18              
  Lines        3848     3888      +40     
==========================================
+ Hits         2020     2029       +9     
- Misses       1828     1859      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmghannam mmghannam merged commit 9e16f75 into master Apr 1, 2024
@Joao-Dionisio Joao-Dionisio deleted the set-locale branch April 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fileformat .cip gives wrong decimal separator at WIN 10

2 participants