Feature: new method addMatrixConsIndicator
#1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to `addConsIndicator` but for matrix
Zeroto521
commented
Jul 13, 2025
|
Thank you, this looks pretty good! Just some minor comments, really |
Condensed the addMatrixConsIndicator method signature to a single line and updated the docstring for improved clarity and consistency. Parameter descriptions were streamlined and default values were explicitly stated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 54.13% 54.33% +0.20%
==========================================
Files 22 22
Lines 5045 5192 +147
==========================================
+ Hits 2731 2821 +90
- Misses 2314 2371 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Specified the return type of the Model.add_matrix_constraint method as MatrixConstraint to improve type clarity and support better static analysis.
Joao-Dionisio
approved these changes
Jul 15, 2025
Co-authored-by: João Dionísio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1021