Skip to content

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Aug 1, 2019

This makes it easier to upgrade later.

@bellet
Copy link
Member

bellet commented Aug 2, 2019

I was confused by the two travis checks but I just realized it must be because @terrytangyuan pushed to a new branch on this repo (not his fork), so I guess this is normal
However I am not sure why there is no test coverage report shown here although a report has been generated, with 2x4 builds (https://codecov.io/github/scikit-learn-contrib/metric-learn/commit/ddca6f3dccbccca902f77da9f00f1154c5b53926)

@terrytangyuan
Copy link
Member Author

Good catch. I’ve fixed the issue with two Travis builds in #242. Not sure about the coverage report though. It looks like a separate issue that needs to be looked into.

@bellet
Copy link
Member

bellet commented Aug 2, 2019

Thanks merging

@bellet bellet merged commit ca1109b into master Aug 2, 2019
@bellet bellet deleted the terrytangyuan-patch-1 branch August 2, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants