Skip to content

[MRG] Fix random state in algorithms #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

[MRG] Fix random state in algorithms #234

merged 1 commit into from
Jul 9, 2019

Conversation

wdevazelhes
Copy link
Member

This sets a random state in the algorithms that didn't have it set, and tests it. See #232 (comment)

@wdevazelhes
Copy link
Member Author

This PR should be ready to merge when tests pass

@bellet
Copy link
Member

bellet commented Jul 5, 2019

LGTM

@bellet bellet added this to the v0.5.0 milestone Jul 5, 2019
@perimosocordiae perimosocordiae merged commit 7d74671 into scikit-learn-contrib:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellet bellet bellet approved these changes

@perimosocordiae perimosocordiae Awaiting requested review from perimosocordiae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wdevazelhes @bellet @perimosocordiae