This repository was archived by the owner on Dec 6, 2023. It is now read-only.
[HOTFIX] fix compatibility with new scikit-learn version #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow using
lightning
with the latest version (0.23.0
) ofscikit-learn
.Right now if you try to upgrade
scikit-learn
,lightning
fails with the error about that it cannot import neitherjoblib
norsix
because they are no longer exist insklearn.externals
:six
was dropped along with Python 2 support.https://scikit-learn.org/stable/whats_new/v0.21.html#sklearn-externals
joblib
is now a dependency:https://scikit-learn.org/stable/whats_new/v0.21.html#miscellaneous
This PR should be treated as a hotfix, and ideally
lightning
should drop the support of Python 2 withsix
dependency.