Sometimes can not grab and move

[kohemon]

Short description

I added the FloatingPanel in the FloatingPanel's ContentView.
In this case, I sometimes can not grab and move the FloatinPanel.
It works in a tracked TableView.

Expected behavior

It should be able to move with GrabberView and Header part.

Steps to reproduce

class FloatingContentViewController: UIViewController {

     override func viewDidLoad() {
        super.viewDidLoad()

        fpc = FloatingPanelController()

        let contentVC = SecondContentViewController()
        fpc.set(contentViewController: contentVC)

        fpc.track(scrollView: contentVC.tableView)

        fpc.addPanel(toParent: self)
       }
}

Environment

FloatinPanel 1.7.2
Xcode 11.2.1
Mac OS 10.15.1 Beta（19B77a)

Installation method
CocoaPods

I attach the URL of the video.
https://imgur.com/a/ouRC62n

[scenee]

I'm wondering why the grabber handle is above the white surface. The panel's pan gesture is only active on the FloatingPanelController.surfaceView. Do you modify contentInsets, containerMargin' or grabber handle position of the FloatingPanelSurfaceView`?

[kohemon]

I'm sorry, I forgot to describe, but I'm setting ContanerMargins.

surfaceView.containerMargins = .init(top: 24.0, left: 0.0, bottom: view.safeAreaInsets.bottom, right: 0.0)

[scenee]

Ok, I got it. Then I tried to reproduce this in the Maps sample app with below patch, but it's working well. So I think other conditions cause this issue 🤔

diff --git a/Examples/Maps/Maps/ViewController.swift b/Examples/Maps/Maps/ViewController.swift
index 73ea5e1..c8c0a9d 100644
--- a/Examples/Maps/Maps/ViewController.swift
+++ b/Examples/Maps/Maps/ViewController.swift
@@ -27,6 +27,7 @@ class ViewController: UIViewController, MKMapViewDelegate, UISearchBarDelegate,
             fpc.surfaceView.cornerRadius = 0.0
         }
         fpc.surfaceView.shadowHidden = false
+        fpc.surfaceView.containerMargins = UIEdgeInsets(top: 44.0, left: 0.0, bottom: 0.0, right: 0.0)
 
         searchVC = storyboard?.instantiateViewController(withIdentifier: "SearchPanel") as? SearchPanelViewController
 

[kohemon]

I created a repository where the problem happens.
It happens from time to time.
I would be grateful if you could point out any implementation issues🙇‍♂️

https://github.com/kohei1218/FloatingPanelSample

[scenee]

@kohei1218 Thank you so much for your work. That's helpful and finally I acknowledged this issue. I appreciate it.

I took a look at the problem, it looked that the pan gesture recognizer of the second panel sometimes doesn't work well because of both of the failure requirement and the captured area.

I will try to fix it. (This might be same as #308.)

[scenee]

I confirm this issue is fixed on fix-2nd-panel-pan-gesture branch! Could you try it?

[kohemon]

It works great!!🙏
Thanks for the wonderful library.
When will this fix be released?

[scenee]

Glad to hear that 🎉 I've added a sample code based on your nice sample for this case.
So I'm going to release it until next weekend 👍

[scenee]

I've released v1.7.3 now. So I close this issue. Thank you for your contribution 👍

[Edited]
I'm sorry I made a mistake on v1.7.3 so Please use v1.7.4.

[kohemon]

Thank you so much for the quick fix!!!!!
And thanks for the wonderful library👍