Skip to content

Conversation

mrdziuban
Copy link

@mrdziuban mrdziuban commented Feb 28, 2025

The only thing blocking this is that Def.inputTaskDyn doesn't exist. It was added in sbt/sbt#8033 but hasn't been released yet.

New blocker after upgrading to sbt 2.0.0-M4 is this error in the tests:

-- [E172] Type Error: /Users/matt/sbt-dependency-submission/sbt-plugin/src/test/scala/ch/epfl/scala/JsonProtocolTests.scala:16:45
16 |    val obtained = Converter.toJson(metadata).get
   |                                             ^
   |Cannot find JsonWriter or JsonFormat type class for Map[String, sjsonnew.shaded.scalajson.ast.unsafe.JValue].
   |I found:
   |
   |    ch.epfl.scala.githubapi.JsonProtocol.mapFormat[String,
   |      sjsonnew.shaded.scalajson.ast.unsafe.JValue](
   |      ch.epfl.scala.githubapi.JsonProtocol.StringJsonKeyFormat,
   |      ch.epfl.scala.githubapi.JsonProtocol.isoStringLongFormat[
   |        sjsonnew.shaded.scalajson.ast.unsafe.JValue](
   |        /* missing */
   |          summon[sjsonnew.IsoStringLong[sjsonnew.shaded.scalajson.ast.unsafe.JValue]
   |            ]
   |      )
   |    )
   |
   |But no implicit values were found that match type sjsonnew.IsoStringLong[sjsonnew.shaded.scalajson.ast.unsafe.JValue].

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the migration to sbt 2.x. It looks good so far.

@mrdziuban mrdziuban changed the title Cross build for sbt 2.0.0-M3 Cross build for sbt 2.0.0-M4 Mar 18, 2025
@mrdziuban
Copy link
Author

@adpi2 the main sources are compiling with sbt 2.0.0-M4 now but the tests won't compile, there are a couple compile errors about finding JsonFormat/JsonWriter instances. I put one in the description of the PR -- do you have any idea how to resolve it?

@mrdziuban mrdziuban changed the title Cross build for sbt 2.0.0-M4 Cross build for sbt 2.0.0-RC6 Oct 3, 2025
@mrdziuban
Copy link
Author

Hey @adpi2, I just pushed an update to sbt 2.0.0-RC6, though the JsonWriter issue still exists. Let me know if you have any thoughts

@mrdziuban
Copy link
Author

I was able to figure out the JsonWriter issue, just needed to get the instance in scope from sbt.protocol.codec.JsonProtocl.given. This should be ready for review now.

@mrdziuban mrdziuban marked this pull request as ready for review October 9, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants