Try get rid of CompletableFuture start using TaskApp #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2025 11:54
preliminary changes to get rid of CompletableFuture from Cli and use Deffered isntead and start using TaskApp instead of App One compile test is failing, not sure if end conditions are ok. It would be good to add some tests
There is still problem with `reflectMain` I am not sure where it is used. At the moment I have changed its signature
wiacekm
force-pushed
the
start-using-task-app
branch
from
09cedbf to
69709d1
Compare
added 8 commits
June 2, 2025 12:30
wiacekm
commented
Jul 1, 2025
| cancel: CompletableFuture[java.lang.Boolean] | ||
| ): Int = { | ||
| cancel: Deferred[MonixTask, Boolean], | ||
| activeCliSessions: Ref[MonixTask, Map[Path, List[CliSession]]] |
There was a problem hiding this comment.
I am not sure about hits change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preliminary changes to get rid of CompletableFuture from Cli and use Deffered isntead and start using TaskApp instead of App
One compile test is failing, not sure if end conditions are ok. It would be good to add some tests