Fix #9631: handle F-bounds in type expansion #9729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OlivierBlanvillain Could you have a look if the change makes sense for match types? |
|
A similar issue (same symptoms) has just been opened: #9782 and it doesn't seem to be fixed by this PR. The interesting part of the stacktrace is: [...]
at dotty.tools.dotc.core.Types$TypeAccumulator.foldOver(Types.scala:5434)
at dotty.tools.dotc.typer.Inferencing$accu$1$.apply(Inferencing.scala:408)
at dotty.tools.dotc.typer.Inferencing$accu$1$.apply(Inferencing.scala:400)
at dotty.tools.dotc.core.Types$TypeAccumulator.foldOver(Types.scala:5465)
at dotty.tools.dotc.typer.Inferencing$accu$1$.apply(Inferencing.scala:408)
at dotty.tools.dotc.typer.Inferencing$.traverse$1(Inferencing.scala:424)
at dotty.tools.dotc.typer.Inferencing$.propagate$4$$anonfun$3(Inferencing.scala:434)
at dotty.runtime.function.JProcedure2.apply(JProcedure2.java:15)
at dotty.runtime.function.JProcedure2.apply(JProcedure2.java:10)
at dotty.tools.dotc.util.SimpleIdentityMap$Map1.foreachBinding(SimpleIdentityMap.scala:61)
at dotty.tools.dotc.typer.Inferencing$.propagate$1(Inferencing.scala:436)
at dotty.tools.dotc.typer.Inferencing$.dotty$tools$dotc$typer$Inferencing$$$variances(Inferencing.scala:441)
at dotty.tools.dotc.typer.Inferencing$.maximizeType(Inferencing.scala:352)
at dotty.tools.dotc.transform.TypeTestsCasts$.typeArgsTrivial$1(TypeTestsCasts.scala:119)
at dotty.tools.dotc.transform.TypeTestsCasts$.recur$1(TypeTestsCasts.scala:155)
at dotty.tools.dotc.transform.TypeTestsCasts$.checkable(TypeTestsCasts.scala:164)
at dotty.tools.dotc.transform.TypeTestsCasts$.interceptWith$2(TypeTestsCasts.scala:351)
at dotty.tools.dotc.transform.TypeTestsCasts$.op$proxy3$1(TypeTestsCasts.scala:367)
at dotty.tools.dotc.transform.TypeTestsCasts$.interceptTypeApply(TypeTestsCasts.scala:368)
at dotty.tools.dotc.transform.Erasure$Typer.typedTypeApply(Erasure.scala:751) |
|
This suggests another place where we need to improve the handling of F-bounded types. I'll propose a fix in another PR. |
|
Superseded by #9816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9631: handle F-bounds in type expansion