Fix #9309: Don't set TypeErrors on trees that are desugared later #9318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting the type of a tree to a type error, we have to make sure the tree is not before desugaring. First, it does not make sense to add a type to a tree that exists only in untyped form. Second, this might miss adding a type to the desugared tree that needs one. This is achieved by splitting the catch-all for TypeErrors between typedUnadapted and adapt.
odersky
added
the
fasttrack
nicolasstucki
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the type of a tree to a type error, we have to make sure the
tree is not before desugaring. First, it does not make sense to add a type
to a tree that exists only in untyped form. Second, this might miss adding
a type to the desugared tree that needs one.
This is achieved by splitting the catch-all for TypeErrors between typedUnadapted
and adapt.