Fix #5413: Add regression tests #9142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoliykmetyuk
approved these changes
Jun 11, 2020
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Aug 18, 2021
…" warning Also, use a more precise term in the error message. Unary method generally means something entirely different! Generally, was it really worth it to go into so much trouble for a warning for an edge case? The previous fix overshot, excluding things that are OK. I still believe it would have been better to do nothing aboit scala#9142. The time we have already spent on this and the number of code lines we use to address the issue is in no relation to the benefit of the fix.
olsdavis
pushed a commit
to olsdavis/dotty
that referenced
this pull request
Apr 4, 2022
…" warning Also, use a more precise term in the error message. Unary method generally means something entirely different! Generally, was it really worth it to go into so much trouble for a warning for an edge case? The previous fix overshot, excluding things that are OK. I still believe it would have been better to do nothing aboit scala#9142. The time we have already spent on this and the number of code lines we use to address the issue is in no relation to the benefit of the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.