Make NonEmptyTuple a Product #9035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
previously requested changes
May 25, 2020
tests/pos/tuple-product.scala
Outdated
| @@ -0,0 +1,5 @@ | |||
| val a: Product = 1 *: () | |||
There was a problem hiding this comment.
This is missing testcases that actually call methods defined on Product and verify they work correctly. (Also I don't know anything about how Tuple is supposed to work, so I don't know if this change is good or bad, someone else should review it)
There was a problem hiding this comment.
I moved the test to tests/run and added some calls to Product methods. Note that in scala.runtime.Tuple we also have plenty of calls to Product on these tuples.
nicolasstucki
force-pushed
the
make-NonEmptyTuple-Product
branch
from
902cef6 to
31b7a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baby step towards #9033