Restore test check function #8787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulpix only checks output if there is an existing check file. Note that partest pos tests used to accept an optional check file, but the confusing behavior is that if you delete the check file, it always passes, unlike a neg test which takes a missing check file as an empty one. In this case, a semantic merge conflict resulted in a neg test with println instead of assert, but with no check file. Happily, such a test can never fail. Sadly, sometimes our code is broken.
dottybot
reviewed
Apr 24, 2020
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
smarter
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulpix only checks output if there is an existing check file.
Note that partest pos tests used to accept an optional check
file, but the confusing behavior is that if you delete the
check file, it always passes, unlike a neg test which takes
a missing check file as an empty one.
In this case, a semantic merge conflict resulted in a neg test
with println instead of assert, but with no check file.
Happily, such a test can never fail. Sadly, sometimes our
code is broken.