Skip to content

Add Reflection constructors for SuperType, RecursiveType and RecursiveThis #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review February 5, 2020 11:30
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* `type T`. This avoids infinite recursions later when we
* try to follow these references.
*/
def RecursiveType_apply(parentExp: RecursiveType => Type)(given ctx: Context): RecursiveType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if there are macros that use recursive types? Scala doesn't have syntax for recursive types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will still get some types that are represented with recursive types in TASTy, hence we need to support it.

@nicolasstucki nicolasstucki merged commit ff93bb1 into scala:master Feb 5, 2020
@nicolasstucki nicolasstucki deleted the add-missing-type-constructors branch February 5, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants