Allow end given as an end marker
#7568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing the wrapper objects for specificity is not enough; we should also look at the resolved methods themselves.
Disallow the previous syntax
```
given (x: T)
... extension methods
```
Require instead
```
given extension (x: T)
... extension methods
```
This avoids the confusion with given instances for types in parentheses and makes
i7515.scala compile. To allow building with 0.20rc1, we allow the old extension syntax
if it comes with a name. E.g. the following is still allowed, but will be dropped
once we have bootstrapped with this commit present.
```
given ops: (x: T)
... extension methods
```
Allow `end given` as an end marker for anonymous givens. These could not have an end marker before. Based on scala#7557.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
end givenas an end marker for anonymous givens.These could not have an end marker before.
Based on #7557.