update scalatest compiler to 0.18.1-RC1 #7163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When we run the community build, the version of dotty in the project is overridden by the version of the current snapshot, so I don't think this needs to be updated. |
|
@smarter Thanks for the point. It's better to make the change, so that we may sync with upstream scalatest. |
|
Why not make the change upstream directly, then update our submodule ? |
|
We don't control the upstream, we'll do it after some refactoring of the recent changes due to 2.13 switch. It will take some time. Meanwhile, it's better to sync our submodule with the community build branch of |
smarter
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update scalatest compiler to 0.18.1-RC1