Skip to content

Fix #6435: Collect variables in quoted patterns #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2019
Merged

Fix #6435: Collect variables in quoted patterns #6465

merged 1 commit into from
May 7, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review May 6, 2019 13:47
@nicolasstucki nicolasstucki requested a review from liufengyun May 6, 2019 13:48
liufengyun
liufengyun approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@nicolasstucki nicolasstucki requested a review from liufengyun May 7, 2019 08:23
liufengyun
liufengyun approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit f54af21 into scala:master May 7, 2019
@nicolasstucki nicolasstucki deleted the fix-#6435 branch May 7, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun