Skip to content

Check for symbol existence when working with GADT bounds in TypeComparer #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2019
Merged

Check for symbol existence when working with GADT bounds in TypeComparer #6431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bdbb4e
Guard against NoSymbol in compareGADT
milessabin May 2, 2019
aafd56e
Move the NoSymbol check to gadtBounds
milessabin May 3, 2019
83cfad9
Use sym.exists
milessabin May 3, 2019
0b57c1d
Only conditionalise adding to footprint
milessabin May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/src/dotty/tools/dotc/core/TypeComparer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2107,17 +2107,17 @@ class TrackingTypeComparer(initctx: Context) extends TypeComparer(initctx) {
}

override def gadtBounds(sym: Symbol)(implicit ctx: Context): TypeBounds = {
footprint += sym.typeRef
if (sym.exists) footprint += sym.typeRef
super.gadtBounds(sym)
}

override def gadtAddLowerBound(sym: Symbol, b: Type): Boolean = {
footprint += sym.typeRef
if (sym.exists) footprint += sym.typeRef
super.gadtAddLowerBound(sym, b)
}

override def gadtAddUpperBound(sym: Symbol, b: Type): Boolean = {
footprint += sym.typeRef
if (sym.exists) footprint += sym.typeRef
super.gadtAddUpperBound(sym, b)
}

Expand Down
9 changes: 9 additions & 0 deletions tests/pos/dep-match.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
object Test {
type Foo = Int { type U }
type Bar[T] = T match {
case Unit => Unit
}
inline def baz(foo: Foo): Unit = {
val v: Bar[foo.U] = ???
}
}