Add fields sorting (primitives first) in case class equals #5838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Feb 4, 2019
smarter
reviewed
Feb 4, 2019
tim-zh
force-pushed
the
sort_fields_in_case_class_equals
branch
from
19443ef to
81537b9
Compare
allanrenucci
reviewed
Feb 4, 2019
tim-zh
force-pushed
the
sort_fields_in_case_class_equals
branch
from
81537b9 to
e2ec1bf
Compare
|
@allanrenucci @smarter Are there more remarks? |
smarter
approved these changes
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of scala/scala/pull/7374
Compare primitive fields first, slow equality checks of non-primitive fields can be skipped when primitives differ.