Skip to content

Fix #209: Add regression test #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2019
Merged

Fix #209: Add regression test #5785

merged 2 commits into from
Jan 24, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jan 23, 2019 •
edited
Loading

Now the copy method of a case class can be overridden with default parameters.

@nicolasstucki nicolasstucki requested a review from smarter January 23, 2019 22:00
@Blaisorblade
Copy link
Contributor

Jason wrote:

The copy method subverts attempts to use private constructors for case
classes so being able to disable its generation is a useful idiom.

Can we test that too?

Blaisorblade
Blaisorblade previously requested changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure any conflicting override of copy disables the default one? (As much as Scalac?) Ones without defaults, with private, etc seem good testcases.

@nicolasstucki nicolasstucki dismissed Blaisorblade’s stale review January 24, 2019 10:22

Added requested tests

@smarter smarter removed their assignment Jan 24, 2019
@nicolasstucki nicolasstucki merged commit a5cca66 into scala:master Jan 24, 2019
@Blaisorblade Blaisorblade deleted the fix-#209 branch January 24, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

+1 more reviewer

@Blaisorblade Blaisorblade Blaisorblade left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @Blaisorblade @smarter