Add tasty seal methods #5603
Merged
Add tasty seal methods #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not include FunctionXXL
nicolasstucki
force-pushed
the
add-tasty-seal-methods
branch
from
7ccacd2 to
46b815d
Compare
nicolasstucki
force-pushed
the
add-tasty-seal-methods
branch
from
46b815d to
761614c
Compare
liufengyun
approved these changes
Dec 13, 2018
| val closureResType = mtpe.resType match { | ||
| case t: MethodType => t.toFunctionType() | ||
| case t => t | ||
| } |
There was a problem hiding this comment.
It seems this does handle param blocks > 2?
There was a problem hiding this comment.
It was working properly but did not fully convert to the lambda type. I changed toFunctionType to make sure it never leaves MethodTypes as result type.
| case 0 => pre.seal[() => Any].apply().unseal | ||
| case 1 => pre.seal[Int => Any].apply('(0)).unseal | ||
| case 2 => pre.seal[(Int, Int) => Any].apply('(0), '(0)).unseal | ||
| case 3 => pre.seal[(Int, Int, Int) => Any].apply('(0), '(0), '(0)).unseal |
There was a problem hiding this comment.
If I understand correctly, this approach will create an unnecessary closure?
There was a problem hiding this comment.
It will create the extra closure, but when the apply is called directly on the seals expression it is beta reduced straight away.
Without this change we got types like `Int => (n: Int): Int`, now we get `Int => Int => Int`. The first type happened to work fine but is not consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.