Fix #4051: Add regression test #4791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wasn't it e42b83e ? |
Contributor
Author
No. It seems that with this commit, you would just trade a |
Blaisorblade
approved these changes
Jul 15, 2018
Contributor
Blaisorblade
left a comment
Blaisorblade
left a comment
There was a problem hiding this comment.
I'd also maybe regression-test the unreduced testcase (Seq(("Porcupine", 1), ("Floyd", 2), ("Phil Collins", 3)).map(_._2)) for more bugs — I've seen patches fix minimizations but not the original testcases.
Otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not entirely sure what fixed it to be honest. Maybe #4604