Fix #4674: Add regression test #4711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Jun 23, 2018
| def T(x: String) = { | ||
| x.foreach { | ||
| case 's' => println("s") | ||
| case c: Char => println(c) // error |
There was a problem hiding this comment.
Can you write // error: type test always succeed instead. Otherwise we don't know what the error is without running the test
| case c: Char => println(c) // error | ||
| } | ||
| } | ||
| T("test") |
There was a problem hiding this comment.
This is not needed. I would remove it. We try to keep tests as small as possible
|
Also please sign the Scala CLA |
|
Done.
Thank you!
… On 23 Jun 2018, at 18:10, Allan Renucci ***@***.***> wrote:
Also please sign the Scala CLA <https://www.lightbend.com/contribute/cla/scala>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#4711 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AaqwDm4z5bNKoAM_1soRAzzKwfcvlKsdks5t_nZqgaJpZM4U002W>.
|
|
CLA signed off. Confirmed from The Scala Team. |
|
CLA signed. Thanks @janrock-ylb for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: Passed