Fix macros with array parameters #4567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-macro-array-params
branch
from
ba1938e to
88bc6bd
Compare
Contributor
Author
|
@biboudis you will need this fix to be able to write the |
biboudis
approved these changes
May 23, 2018
| /** The `Class[_]` of a primitive value type name */ | ||
| def valueTypeNameToJavaType(name: TypeName)(implicit ctx: Context): Option[Class[_]] = | ||
| valueTypeNamesToJavaType.get(if (name.firstPart eq nme.scala_) name.lastPart.toTypeName else name) | ||
| // /** The `Class[_]` of a primitive value type name */ |
Contributor
There was a problem hiding this comment.
I guess this should remain commented-out and not removed, right?
Contributor
Author
There was a problem hiding this comment.
Yes, in case we need it for something else again. It was really useful the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to convert names in the form
scala.Int[]to[I,scala.Int[][]to[[I,java.lang.String[]to[Ljava.lang.String;and so on.