Skip to content

Fix #4455: Lift inlined values when quoted #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2018

Conversation

nicolasstucki
Copy link
Contributor

This is part of the transformation that allows compiling
the contents of the inline macro. The alternative would be to
pass each inline parameter twice, once as a value and once as
it's tree.

This is part of the transformation that allows compiling
the contents of the inline macro. The alternative would be to
pass each inline parameter twice, once as a value and once as
it's tree.
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

def bar(x: Expr[Int]): Expr[Int] = x

inline def foo2(inline i: Int): Int = ~bar('(i + 1))
def bar2(x: Expr[Int]): Expr[Int] = x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bar2 is unused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I only need one of them. Will remove it.

@nicolasstucki nicolasstucki merged commit 6f6816d into scala:master May 4, 2018
@Blaisorblade Blaisorblade deleted the fix-#4455 branch May 4, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants