Fix bridge generation for object definitions #4435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not generate a bridge of the overriding definition was a static object. This caused AbstractMethodError crashes at run time.
nicolasstucki
approved these changes
May 2, 2018
| @@ -542,6 +542,9 @@ object Flags { | |||
| /** Either method or lazy */ | |||
| final val MethodOrLazy = Method | Lazy | |||
|
|
|||
| /** Either method or module */ | |||
| final val MethodOrModule = Method | Module | |||
There was a problem hiding this comment.
Do we really need to define a new one for only one use?
There was a problem hiding this comment.
It's slightly more efficient that way. The | computation takes time, it's not just a simple bitwise |.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not generate a bridge if the overriding definition was a static object.
This caused AbstractMethodError crashes at run time.