vscode-dotty: Compile typescript with --strict #4113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Mar 13, 2018
smarter
approved these changes
Mar 14, 2018
vscode-dotty/package.json
Outdated
| "compile": "./node_modules/.bin/tsc -p ./", | ||
| "update-all": "npm install && node ./node_modules/vscode/bin/install && curl -L -o out/coursier https://github.com/coursier/coursier/raw/v1.0.0/coursier", | ||
| "test": "node ./node_modules/vscode/bin/test" | ||
| "update-all": "npm install", |
There was a problem hiding this comment.
I think I would keep this as it was before, it matches how other vscode extensions do it.
There was a problem hiding this comment.
Do you know why it is done this way? This is exaclty the use case postinstall was made for.
There was a problem hiding this comment.
I just checked and the default template does use postinstall instead of update-all now actually, so this change is fine but we should get rid of update-all while we're at it.
jendrikw
force-pushed
the
compile-typescript-with-strict
branch
from
a748e74 to
385b6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling typescript with the strict option is generally recommend to catch more type errors.
Also, I changed the update-all to a postinstall script, which will automatically execute after every
npm install.