Skip to content

Conversation

jendrikw
Copy link

@jendrikw jendrikw commented Mar 13, 2018

Compiling typescript with the strict option is generally recommend to catch more type errors.

Also, I changed the update-all to a postinstall script, which will automatically execute after every npm install.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

"compile": "./node_modules/.bin/tsc -p ./",
"update-all": "npm install && node ./node_modules/vscode/bin/install && curl -L -o out/coursier https://github.com/coursier/coursier/raw/v1.0.0/coursier",
"test": "node ./node_modules/vscode/bin/test"
"update-all": "npm install",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would keep this as it was before, it matches how other vscode extensions do it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why it is done this way? This is exaclty the use case postinstall was made for.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and the default template does use postinstall instead of update-all now actually, so this change is fine but we should get rid of update-all while we're at it.

@jendrikw jendrikw force-pushed the compile-typescript-with-strict branch from a748e74 to 385b6ce Compare March 14, 2018 16:09
@smarter smarter merged commit 6ac9bf2 into scala:master Mar 14, 2018
@jendrikw jendrikw deleted the compile-typescript-with-strict branch March 18, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants