Fix #3914: Add compiler args to quote run and show Settings #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be useful for debugging. |
liufengyun
approved these changes
Feb 8, 2018
| val ctx: Context = initCtx.fresh | ||
| ctx.settings.optimise.update(settings.optimise)(ctx) | ||
| def run[T](expr: Expr[T], settings: Settings[Run]): T = { | ||
| val (_, ctx: Context) = setup(settings.compilerArgs.toArray :+ "dummy.scala", initCtx.fresh) |
There was a problem hiding this comment.
setup expects some input file. But it is not required here. Hence I add a dummy file name that is then ignored. It is the _ in val (_, ctx: Context) =
| val ctx: Context = initCtx.fresh | ||
| ctx.settings.color.update("never")(ctx) // TODO support colored show | ||
| def withTree[T](expr: Expr[_], f: (Tree, Context) => T, settings: Settings[_]): T = { | ||
| val (_, ctx: Context) = setup(settings.compilerArgs.toArray :+ "dummy.scala", initCtx.fresh) |
nicolasstucki
force-pushed
the
fix-#3914
branch
from
82977c3 to
02b1774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.