Skip to content

Fix #746: Generate efficient try cases for parameterized exceptions #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 26, 2018

We were missing a case for AppliedType

@odersky
Copy link
Contributor Author

odersky commented Jan 26, 2018

I agree with @smarter's comment on #3928 that it would be good to have a bytecode test. I don't know enough about the bytecode testing framework to be able to do one quickly, though. So if someone else wants to add one, please do!

@allanrenucci allanrenucci self-assigned this Jan 26, 2018
@allanrenucci
Copy link
Contributor

The CI failure should go away after rebasing. I can do it while adding a bytecode test

@odersky
Copy link
Contributor Author

odersky commented Jan 28, 2018

@allanrenucci Thanks for the test!

@odersky odersky merged commit cdc25fd into scala:master Jan 28, 2018
@allanrenucci allanrenucci deleted the fix-#746 branch January 28, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants