Fix #3873: Properly unpickle shared TypeTrees #3874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-shared-tpt-again
branch
from
41cbd36 to
fbbb7c2
Compare
When a TypeTree is represented by a SHAREDterm, we need to follow the SHAREDterm and call `readTpt()` again. We cannot rely on `readTerm()` following the SHAREDterm for us because a TypeTree can be pickled as just a type.
smarter
force-pushed
the
fix-shared-tpt-again
branch
from
fbbb7c2 to
47e604d
Compare
odersky
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TypeTree is represented by a SHAREDterm, we need to follow the
SHAREDterm and call
readTpt()again. We cannot rely onreadTerm()following the SHAREDterm for us because a TypeTree can be pickled as
just a type.