Make Ycheck stricter #3763
Merged
Make Ycheck stricter #3763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
force-pushed
the
ycheck
branch
2 times, most recently
from
900913e to
cc5740a
Compare
allanrenucci
commented
Mar 28, 2018
| if (this.flatClasses) { | ||
| registry.get(name) match { | ||
| case Some(prev) => | ||
| assert(sym eq prev, i"$typ defined twice $sym ${sym.id} ${prev.id}") |
There was a problem hiding this comment.
The same symbol goes through def transformSym(symd: SymDenotation)(implicit ctx: Context): SymDenotation multiple times. Is this expected?
smarter
approved these changes
Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that in some cases Ycheck would print an error but not fail. Is it intended?