Fix #3443: adapt child compatibility check #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBlanvillain
approved these changes
Nov 8, 2017
| @@ -778,41 +780,41 @@ class SpaceEngine(implicit ctx: Context) extends SpaceLogic { | |||
| * | |||
| * A <: X :> Y B <: U :> V M { type T <: A :> B } ~~> M { type T <: X :> V } | |||
| */ | |||
| def expose(tp: Type, refineCtx: Boolean = false, up: Boolean = true): Type = tp match { | |||
| def expose(tp: Type, up: Boolean = true): Type = tp match { | |||
There was a problem hiding this comment.
I would remove the default = true here
There was a problem hiding this comment.
I just removed the whole method :)
| else if (variance == 1) expose(tp, true) | ||
| else expose(tp, false) | ||
|
|
||
| debug.println(s"$tp exposed to =====> " + exposed) |
There was a problem hiding this comment.
You could put $exposed inside the string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3443
Previously, the child compatibility check will result in a check like
CNil <: TVar(Nothing..Coproduct), which failed. Now we expose type param according to its variance. We only resort toTVarif the variance is 0.This PR also removes the
@uncheckedcheck, as agreed with @allanrenucci the check should be somewhere else and handle more complex cases.