New format of illegal start of statement error message (+tests) #3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS. I've signed the CLA |
allanrenucci
suggested changes
Nov 3, 2017
| @@ -2496,8 +2496,7 @@ object Parsers { | |||
| } | |||
| else if (!isStatSep && (in.token != CASE)) { | |||
| exitOnError = mustStartStat | |||
| val addendum = if (isModifier) " (no modifiers allowed here)" else "" | |||
| syntaxErrorOrIncomplete("illegal start of statement" + addendum) | |||
| syntaxErrorOrIncomplete(IllegalStartOfStatement(isModifier = isModifier)) | |||
There was a problem hiding this comment.
Named argument is redundant here
|
|
||
| case class IllegalStartOfStatement(isModifier: Boolean)(implicit ctx: Context) extends Message(IllegalStartOfStatementID) { | ||
| val kind = "Syntax" | ||
| private val addendum = if(isModifier) "(no modifiers allowed here)" else "" |
There was a problem hiding this comment.
Make it a nested val:
val msg = {
val addentum = ...
"..." + addentum
}| val explanation = hl""" | ||
| | Expected an import, a statement or an expression at the start of a statement. | ||
| | For a detailed list of allowed statements, please consult the syntax of BlockStat at http://dotty.epfl.ch/docs/internals/syntax.html#expressions | ||
| """ |
There was a problem hiding this comment.
For now, we don't include links. Suggested rephrasing:
val explanation = "A statement is either an import, a definition or an expression."| | { ) } | ||
| | { private ) } | ||
| |} | ||
| | |
| | Expected an import, a statement or an expression at the start of a statement. | ||
| | For a detailed list of allowed statements, please consult the syntax of BlockStat at http://dotty.epfl.ch/docs/internals/syntax.html#expressions | ||
| """ | ||
|
|
karolchmist
force-pushed
the
illegal-start-of-statement-error-messages
branch
3 times, most recently
from
8ff1da0 to
f2a9eab
Compare
|
Thanks @allanrenucci, I've committed the requested changes. |
allanrenucci
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1589.
Uses new format of error messages in Parsers.scala:2500
The new error is IllegalStartOfStatement