Change variances in TypeMaps and Accumulators #2934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jul 30, 2017
| // would not detect types to be compatible. Note: If we replace the | ||
| // 2nd condition by `defDenot.symbol.maybeOwner.isType` we get lots | ||
| // of failures in the `tastyBootstrap` test. Trying to compile these | ||
| // files in isolation works though. |
There was a problem hiding this comment.
testPickling also failed, here's a simplified way to reproduce the failure:
./bin/dotc -Xprint-types -Ytest-pickler compiler/src/dotty/tools/io/File.scala compiler/src/dotty/tools/io/Jar.scalaThis fails with a pickling difference, here's the diff:
--- before-pickling.txt 2017-07-30 16:10:33.955539823 +0200
+++ after-pickling.txt 2017-07-30 16:10:33.955539823 +0200
@@ -111,7 +111,7 @@
<<new java.util.jar.JarFile:java.util.jar.JarFile>:
((x$0: java.io.File): java.util.jar.JarFile)
>
- (<<Jar.this.file:dotty.tools.io.File>.jfile:=> dotty.tools.io.JFile>):
+ (<<Jar.this.file:dotty.tools.io.File>.jfile:<notype>>):
java.util.jar.JarFile
>
lazy val manifest: scala.Option[java.util.jar.Manifest] = 
Bonus point: No need to override applyPrefix in variances accumulator. This means we have reduced three different ways to compute the current variance to one.
odersky
force-pushed
the
change-variances
branch
from
d351c64 to
8683f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2932.
Also contains the owner change for typed idents.