Skip to content

Make nesting/owner a real ordering for implicit search #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2017
Merged

Make nesting/owner a real ordering for implicit search #2839

merged 1 commit into from
Jul 6, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 6, 2017

We pick nesting first, owner hierarchy second.

@odersky odersky requested a review from smarter July 6, 2017 12:28
smarter
smarter approved these changes Jul 6, 2017
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some tests would be nice.

@odersky odersky merged commit dd517c5 into scala:master Jul 6, 2017
@allanrenucci allanrenucci deleted the change-implsearch-spec branch December 14, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @smarter