Skip to content

Allow multiple calls to checkMessagesAfter in ErrorMessagesTests #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2017

Conversation

felixmulder
Copy link
Contributor

@felixmulder felixmulder commented Jul 5, 2017

This solves the issue @bbarker was having with regards to runs.

Second commit simply cleans up formatting of ErrorMessagesTests file.

@felixmulder felixmulder requested a review from smarter July 5, 2017 08:29
smarter
smarter previously requested changes Jul 5, 2017
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM


private def freshReporter(ctx: Context) =
ctx.fresh.setReporter(new CapturingReporter)
private def freshReporter(ctx: Context) = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the ctx argument anymore.

@felixmulder felixmulder force-pushed the fix/error-messages-calls branch from e1bc43f to ccfb726 Compare July 5, 2017 08:39
@felixmulder felixmulder force-pushed the fix/error-messages-calls branch from c2f4531 to 0a7e4dd Compare July 5, 2017 09:46
@felixmulder felixmulder dismissed smarter’s stale review July 5, 2017 10:57

confirmed verbally

@felixmulder felixmulder merged commit 7820b5f into scala:master Jul 5, 2017
@allanrenucci allanrenucci deleted the fix/error-messages-calls branch December 14, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants