Changes around reaches and uses #23584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind, those changes are relevant to the spine-capture-set refactor, not this one. I mixed the contexts up. |
|
Closing for now since too much has diverged. |
|
Closing for now since this diverged too much from main. |
Several TODOs need follow-up
odersky
commented
Aug 7, 2025
| case tp: TypeRef if tp.symbol == defn.Caps_CapSet => | ||
| // This can happen in cases where we try to type an eta expansion `$x => f($x)` | ||
| // from a polymorphic target type using capture sets. In that case the parameter type | ||
| // of $x is not treated as inferred is approximated to CapSet. An example is |
There was a problem hiding this comment.
Suggested change
| // of $x is not treated as inferred is approximated to CapSet. An example is | |
| // of $x is not treated as inferred and is approximated to CapSet. An example is |
|
Is this PR ready for being reviewed? |
|
Yes, ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.