[stdlib] Pin scala3 files before merging the full history #23517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
changed the title
natsukagami
approved these changes
Jul 14, 2025
| @@ -1138,7 +1138,275 @@ object Build { | |||
| ) | |||
|
|
|||
| lazy val `scala3-library` = project.in(file("library")).asDottyLibrary(NonBootstrapped) | |||
| .settings( | |||
| // Note: extracted using `print scala3-library / Compile / sources` | |||
| // Only keep scala3 files until 3.8.0 | |||
There was a problem hiding this comment.
Note to self: this means after 3.8 we will remove this and have the full stdlib
I trust MiMa would have complained if something was missing! |
hamzaremmal
added a commit
that referenced
this pull request
Jul 14, 2025
#23518) Follows #23517 The compiler adds the `sourceDirectories` as an option so that it can load the definitions from the stdlib. Now, instead of adding the directories, we just add the pinned files. This has been missing when I merged locally the scala 2 history. With this change, everything behaves as expected when I opened #23517.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging the history of the scala 2 library with Dotty, we first pin the set of files to be compiled for now.
This will change in 3.8.0 when we bundle all the files of the scala 3 library in the same jar and drop the dependency to scala2 stdlib
[test_non_bootstrapped]