Skip to content

Fix main: remove empty parentheses when rewriting implicits to givens #23339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix main: remove empty parentheses when rewriting implicits to givens #23339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions compiler/src/dotty/tools/dotc/typer/Migrations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ trait Migrations:
patch(
Span(ddef.mods.mods.last.span.end + 1, ddef.namePos.span.start), "given "
)
// remove empty parentheses
patch(
Span(ddef.namePos.span.end, ddef.tpt.span.start), ": "
)
ddef.tpt match
case refinedType: untpd.RefinedTypeTree =>
patch(refinedType.span.startPos, "(")
Expand Down
2 changes: 1 addition & 1 deletion tests/rewrites/implicit-to-given.check
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ object Def:
val application = applicationTest(using 0)
val implicitArg: Int => Unit = (implicit a => applicationTest) // should not change

given refined(): (A {type B = Int}) = ???
given refined: (A {type B = Int}) = ???

class EmptyParamListClass()(using a: Int)
def emptyParamListTest() = new EmptyParamListClass()(using 0)
Loading